fix corner case of plethysm with tensors #41257
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@anneschilling @tscrim @mantepse Fixing a corner case. |
anneschilling
suggested changes
Dec 3, 2025
Co-authored-by: Anne Schilling <[email protected]>
anneschilling
approved these changes
Dec 3, 2025
Contributor
anneschilling
left a comment
anneschilling
left a comment
There was a problem hiding this comment.
Looks good! Wait for patchbot to check and then set positive review.
mantepse
reviewed
Dec 3, 2025
Co-authored-by: Martin Rubey <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a corner case of the plethysm function that was failing when computing a plethysm of an empty partition and a tensor of symmetric functions.
This change inserts the base case of a product in the plethsym formula as a default of 1 to the .one() of the ring.
📝 Checklist
⌛ Dependencies